bug: go back to old behavior of dropping {} for tools #571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is probably the wrong thing to do. We need to differientiate
between empty args and no args. If a tool has no params defined
then {} should be dropped. Right now this logic is in the wrong spot
to do that so we just go back to the old behavior of just always dropping
{} which will cause a problem for tools that would expect an empty object.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably the wrong thing to do. We need to differientiate
between empty args and no args. If a tool has no params defined
then {} should be dropped. Right now this logic is in the wrong spot
to do that so we just go back to the old behavior of just always dropping
{} which will cause a problem for tools that would expect an empty object.